Nathanielbibler simplepay

This is my first ticket on lighthouse so excuse me if I miss something.

It seems that the valid_simplepay_request? method in /lib/simplepay/helpers/notifcation_helper.rb doesn't return valid because of the :controller and :action params in the params hash that gets sent back to the return URL.

When the :controller => 'mycontroller' and :action => 'return' get put into the signature it doesn't match the signature calculated by amazon on the return.

In the valid_simplepay_request? method I added:

  hash.delete(:controller)
  hash.delete(:action)

That seems to allow the generated signature match the signature sent from amazon.

The final method is:

  def valid_simplepay_request?(request_hash)

hash = request_hash.symbolize_keys
signature = hash.delete(:signature) || ''
hash.delete(:controller)
hash.delete(:action)
Simplepay::Authentication.authentic?(hash, signature)

  end

Hope that helps.